Berack/upo-app-agents
0
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

feat: make configs.yaml local and add configs.yaml.example template #56

Closed
Simo93-rgb wants to merge 3 commits from 55-configsyaml-condivisi into main
pull from: 55-configsyaml-condivisi
merge into: Berack:main
Conversation 5 Commits 3 Files Changed 3 +24 -8
Simo93-rgb commented 2025-10-29 14:19:00 +01:00 (Migrated from github.com)
Copy Link
  • Add configs.yaml.example with all available configurations
  • Add configs.yaml to .gitignore to prevent tracking local configs
  • Remove configs.yaml from git tracking with git rm --cached
  • Update README with separate sections for configs.yaml and .env
  • Maintain consistent naming convention with .env.example
- Add configs.yaml.example with all available configurations - Add configs.yaml to .gitignore to prevent tracking local configs - Remove configs.yaml from git tracking with git rm --cached - Update README with separate sections for configs.yaml and .env - Maintain consistent naming convention with .env.example
copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed 2025-10-29 14:20:21 +01:00
copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment
Copy Link

Pull Request Overview

This pull request updates the configuration file naming from config.yaml to configs.yaml and improves the project's configuration documentation. The PR enables the previously commented Gemini Pro model, upgrades agent model specifications to use larger qwen3 variants, and adds configs.yaml to .gitignore to prevent tracking of local configurations.

Key changes:

  • Uncommented and enabled gemini-2.0-pro model configuration
  • Upgraded agent models from smaller variants (1.7b, 4b) to qwen3:8b for improved performance
  • Enhanced README documentation with structured sections for configuration setup
  • Added configs.yaml to .gitignore to support local development configurations

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
configs.yaml.example Enabled Gemini Pro model and upgraded agent models to qwen3:8b variants
README.md Expanded configuration documentation with separate subsections for app config and environment variables, added instructions for creating local configs.yaml
.gitignore Added configs.yaml to prevent tracking local configuration files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

## Pull Request Overview This pull request updates the configuration file naming from `config.yaml` to `configs.yaml` and improves the project's configuration documentation. The PR enables the previously commented Gemini Pro model, upgrades agent model specifications to use larger qwen3 variants, and adds `configs.yaml` to `.gitignore` to prevent tracking of local configurations. **Key changes:** - Uncommented and enabled `gemini-2.0-pro` model configuration - Upgraded agent models from smaller variants (1.7b, 4b) to `qwen3:8b` for improved performance - Enhanced README documentation with structured sections for configuration setup - Added `configs.yaml` to `.gitignore` to support local development configurations ### Reviewed Changes Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment. | File | Description | | ---- | ----------- | | configs.yaml.example | Enabled Gemini Pro model and upgraded agent models to qwen3:8b variants | | README.md | Expanded configuration documentation with separate subsections for app config and environment variables, added instructions for creating local configs.yaml | | .gitignore | Added configs.yaml to prevent tracking local configuration files | --- 💡 <a href="/Berack96/upo-appAI/new/main/.github?filename=*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>.
README.md
@@ -45,6 +57,9 @@ Nel file [.env.example](.env.example) sono presenti tutte le variabili da compil
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2025-10-29 14:20:21 +01:00
Copy Link

[nitpick] The reference to model in the original text was corrected to models, but this sentence could be clearer. The phrase 'alla voce models' is somewhat ambiguous. Consider specifying that it refers to the models section in the configuration file, or provide an example path like models.ollama for better clarity.

I modelli usati dall'applicazione sono quelli specificati nella sezione `models` del file di configurazione `configs.yaml` (ad esempio `models.ollama`). Se in locale si hanno dei modelli diversi, è possibile modificare il file `configs.yaml` per usare quelli disponibili.
[nitpick] The reference to `model` in the original text was corrected to `models`, but this sentence could be clearer. The phrase 'alla voce `models`' is somewhat ambiguous. Consider specifying that it refers to the `models` section in the configuration file, or provide an example path like `models.ollama` for better clarity. ```suggestion I modelli usati dall'applicazione sono quelli specificati nella sezione `models` del file di configurazione `configs.yaml` (ad esempio `models.ollama`). Se in locale si hanno dei modelli diversi, è possibile modificare il file `configs.yaml` per usare quelli disponibili. ```
Berack96 (Migrated from github.com) reviewed 2025-10-29 15:05:29 +01:00
configs.yaml
Berack96 (Migrated from github.com) commented 2025-10-29 15:05:13 +01:00
Copy Link

Hai controllato che funzionasse? Perché avevo messo il commento che non funzionava e aveva un nome diverso

Hai controllato che funzionasse? Perché avevo messo il commento che non funzionava e aveva un nome diverso
filibertomelis-ors (Migrated from github.com) approved these changes 2025-10-29 15:40:19 +01:00
trojanhorse47 (Migrated from github.com) approved these changes 2025-10-29 16:02:06 +01:00
trojanhorse47 (Migrated from github.com) approved these changes 2025-10-29 16:02:57 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
copilot-pull-request-reviewer[bot]
Berack96
filibertomelis-ors
trojanhorse47
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 important
This is a core feature that must be worked on as soon as possible
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Berack
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Berack/upo-app-agents#56
Delete Branch "55-configsyaml-condivisi"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?