Berack/upo-app-agents
0
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Fix chat defaults #46

Merged
Berack96 merged 5 commits from fix-chat-default-model into main 2025-10-27 12:41:50 +01:00
Conversation 3 Commits 5 Files Changed 1 +3 -1
Berack96 commented 2025-10-24 18:37:49 +02:00 (Migrated from github.com)
Copy Link

Aggiornato il gestore della chat per impostare i valori predefiniti per il modello e la strategia nel dropdown.

Aggiornato il gestore della chat per impostare i valori predefiniti per il modello e la strategia nel dropdown.
trojanhorse47 (Migrated from github.com) reviewed 2025-10-24 18:37:49 +02:00
copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed 2025-10-24 18:38:23 +02:00
copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment
Copy Link

Pull Request Overview

This PR fixes the initialization of default values in the chat interface dropdowns. The changes ensure that both the model (provider) and investment style (strategy) dropdowns display their currently selected values when the interface loads, improving the user experience by making the current configuration immediately visible.

Key Changes:

  • Set default value for the provider dropdown to match the selected team leader model
  • Renamed style variable to strategy for consistency with related method names
  • Set default value for the strategy dropdown to match the selected strategy

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

## Pull Request Overview This PR fixes the initialization of default values in the chat interface dropdowns. The changes ensure that both the model (provider) and investment style (strategy) dropdowns display their currently selected values when the interface loads, improving the user experience by making the current configuration immediately visible. **Key Changes:** - Set default value for the provider dropdown to match the selected team leader model - Renamed `style` variable to `strategy` for consistency with related method names - Set default value for the strategy dropdown to match the selected strategy --- 💡 <a href="/Berack96/upo-appAI/new/main/.github?filename=*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>.
src/app/interface/chat.py
@@ -80,3 +80,4 @@
provider = gr.Dropdown(
choices=self.inputs.list_models_names(),
value=self.inputs.team_leader_model.label,
type="index",
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2025-10-24 18:38:23 +02:00
Copy Link

Setting value directly on a Gradio component after creation may not update the displayed default. Consider using the value parameter in the gr.Dropdown() constructor instead: value=self.inputs.team_leader_model.label.

Setting `value` directly on a Gradio component after creation may not update the displayed default. Consider using the `value` parameter in the `gr.Dropdown()` constructor instead: `value=self.inputs.team_leader_model.label`.
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2025-10-24 18:38:23 +02:00
Copy Link

Setting value directly on a Gradio component after creation may not update the displayed default. Consider using the value parameter in the gr.Dropdown() constructor instead: value=self.inputs.strategy.label.

Setting `value` directly on a Gradio component after creation may not update the displayed default. Consider using the `value` parameter in the `gr.Dropdown()` constructor instead: `value=self.inputs.strategy.label`.
Simo93-rgb (Migrated from github.com) approved these changes 2025-10-27 12:41:48 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
trojanhorse47
copilot-pull-request-reviewer[bot]
Simo93-rgb
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 important
This is a core feature that must be worked on as soon as possible
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label bug important
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Berack
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Berack/upo-app-agents#46
Delete Branch "fix-chat-default-model"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?