Refactor try_call_all method to return a dictionary of results; update tests for success and partial failures

src/app/utils/wrapper_handler.py

@@ -61,7 +61,7 @@ class WrapperHandler(Generic[W]):
 
         raise Exception(f"All wrappers failed after retries")
 
-    def try_call_all(self, func: Callable[[W], T]) -> list[T]:
+    def try_call_all(self, func: Callable[[W], T]) -> dict[str, T]:
         """
         Calls the provided function on all wrappers, collecting results.
         If a wrapper fails, it logs a warning and continues with the next.
@@ -73,11 +73,11 @@ class WrapperHandler(Generic[W]):
         Raises:
             Exception: If all wrappers fail.
         """
-        results = []
+        results = {}
         for wrapper in self.wrappers:
             try:
                 result = func(wrapper)
-                results.append(result)
+                results[wrapper.__class__] = result
             except Exception as e:
                 log_warning(f"{wrapper} failed: {e}")
         if not results:

tests/utils/test_wrapper_handler.py

@@ -5,6 +5,10 @@ class MockWrapper:
     def do_something(self) -> str:
         return "Success"
 
+class MockWrapper2(MockWrapper):
+    def do_something(self) -> str:
+        return "Success 2"
+
 class FailingWrapper(MockWrapper):
     def do_something(self):
         raise Exception("Intentional Failure")
@@ -59,19 +63,26 @@ class TestWrapperHandler:
         assert handler.index == 1  # Should return to the second wrapper after failure
         assert handler.retry_count == 0
 
-    def test_try_call_all(self):
+    def test_try_call_all_success(self):
+        wrappers = [MockWrapper, MockWrapper2]
+        handler: WrapperHandler[MockWrapper] = WrapperHandler.build_wrappers(wrappers, try_per_wrapper=1, retry_delay=0)
+        results = handler.try_call_all(lambda w: w.do_something())
+        assert results == {MockWrapper: "Success", MockWrapper2: "Success 2"}
+
+    def test_try_call_all_partial_failures(self):
+        # Only the second wrapper should succeed
         wrappers = [FailingWrapper, MockWrapper, FailingWrapper]
         handler: WrapperHandler[MockWrapper] = WrapperHandler.build_wrappers(wrappers, try_per_wrapper=1, retry_delay=0)
-
         results = handler.try_call_all(lambda w: w.do_something())
-        assert results == ["Success"]  # Only the second wrapper should succeed
+        assert results == {MockWrapper: "Success"}
 
-        wrappers = [FailingWrapper, MockWrapper, FailingWrapper, MockWrapper]
+        # Only the second and fourth wrappers should succeed
+        wrappers = [FailingWrapper, MockWrapper, FailingWrapper, MockWrapper2]
         handler: WrapperHandler[MockWrapper] = WrapperHandler.build_wrappers(wrappers, try_per_wrapper=1, retry_delay=0)
-
         results = handler.try_call_all(lambda w: w.do_something())
-        assert results == ["Success", "Success"]  # Only the second and fourth wrappers should succeed
+        assert results == {MockWrapper: "Success", MockWrapper2: "Success 2"}
 
+    def test_try_call_all_all_fail(self):
         # Test when all wrappers fail
         handler_all_fail: WrapperHandler[MockWrapper] = WrapperHandler.build_wrappers([FailingWrapper, FailingWrapper], try_per_wrapper=1, retry_delay=0)
         with pytest.raises(Exception) as exc_info: