Berack/upo-app-agents
0
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Team Workflow aggiornato #37

Merged
Berack96 merged 16 commits from 19-team-instructions into main 2025-10-20 22:05:58 +02:00
Conversation 3 Commits 16 Files Changed 19 +3 -3
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 594dcd0aa6 - Show all commits

4
configs.yaml
View File

@@ -41,7 +41,7 @@ api:
agents: agents:
copilot-pull-request-reviewer[bot] commented 2025-10-20 18:05:29 +02:00 (Migrated from github.com)
Review
Copy Link

The predictor_model configuration field appears to be unused after the refactoring that replaced it with query_analyzer_model and report_generation_model. This configuration should be removed to avoid confusion.
The `predictor_model` configuration field appears to be unused after the refactoring that replaced it with `query_analyzer_model` and `report_generation_model`. This configuration should be removed to avoid confusion. ```suggestion ```
strategy: Conservative strategy: Conservative
team_model: qwen3:1.7b team_model: qwen3:1.7b
team_leader_model: qwen3:4b team_leader_model: qwen3:8b
query_analyzer_model: qwen3:4b query_analyzer_model: qwen3:4b
report_generation_model: qwen3:4b report_generation_model: qwen3:8b
predictor_model: qwen3:4b predictor_model: qwen3:4b

2
src/app/agents/core.py
View File

@@ -44,7 +44,7 @@ class PipelineInputs:
""" """
Sceglie il modello LLM da usare per il Team Leader. Sceglie il modello LLM da usare per il Team Leader.
""" """
self.leader_model = self.configs.models.all_models[index] self.team_leader_model = self.configs.models.all_models[index]
def choose_team(self, index: int): def choose_team(self, index: int):
copilot-pull-request-reviewer[bot] commented 2025-10-20 18:05:28 +02:00 (Migrated from github.com)
Review
Copy Link

Variable assignment uses team_leader_model instead of leader_model as mentioned in the method's docstring. The docstring should be updated or the variable name should be consistent.

Variable assignment uses `team_leader_model` instead of `leader_model` as mentioned in the method's docstring. The docstring should be updated or the variable name should be consistent.
copilot-pull-request-reviewer[bot] commented 2025-10-20 21:51:58 +02:00 (Migrated from github.com)
Review
Copy Link

The choose_team_leader method assigns to self.team_leader_model but the initialization in __init__ uses a different assignment pattern via get_model_by_name(). This inconsistency means the model assignment won't have the same validation and could break if index is out of bounds. Use self.team_leader_model = self.configs.models.all_models[index] with proper validation or use the same pattern as __init__.

        model_list = self.configs.models.all_models
        if 0 <= index < len(model_list):
            model_name = model_list[index].name
            self.team_leader_model = self.configs.get_model_by_name(model_name)
        else:
            raise IndexError(f"Model index {index} out of range for team leader selection.")
The `choose_team_leader` method assigns to `self.team_leader_model` but the initialization in `__init__` uses a different assignment pattern via `get_model_by_name()`. This inconsistency means the model assignment won't have the same validation and could break if `index` is out of bounds. Use `self.team_leader_model = self.configs.models.all_models[index]` with proper validation or use the same pattern as `__init__`. ```suggestion model_list = self.configs.models.all_models if 0 <= index < len(model_list): model_name = model_list[index].name self.team_leader_model = self.configs.get_model_by_name(model_name) else: raise IndexError(f"Model index {index} out of range for team leader selection.") ```
""" """