Configurazioni dell'app #27

2025-10-11T23:41:41+02:00

Berack96 commented

2025-10-11 23:41:41 +02:00

(Migrated from github.com)

Messo in una cartella apposta i prompt
Create delle configurazioni dell'app e rimesso a posto delle parti statiche di codice come configs

Messo in una cartella apposta i prompt Create delle configurazioni dell'app e rimesso a posto delle parti statiche di codice come configs

copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed 2025-10-12 17:56:25 +02:00

copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment

Pull Request Overview

This PR reorganizes the application structure by moving prompts to a dedicated folder and creating centralized app configurations. The main goal is to improve code organization and replace hardcoded static configurations with a configurable system.

Moved prompt definitions from inline code to external text files in src/app/agents/prompts/
Created a comprehensive configuration system with AppConfig class and YAML configuration file
Reorganized API tools into a dedicated tools module and refactored import paths accordingly

Reviewed Changes

Copilot reviewed 43 out of 49 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/app/configs.py	Implements comprehensive application configuration system with YAML loading and model validation
src/app/agents/prompts/	Extracts hardcoded prompts into organized text files
src/app/api/tools/	Consolidates API tool classes into dedicated module
tests/	Updates import paths to reflect new module structure
configs.yaml	Adds YAML configuration file for application settings

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

## Pull Request Overview This PR reorganizes the application structure by moving prompts to a dedicated folder and creating centralized app configurations. The main goal is to improve code organization and replace hardcoded static configurations with a configurable system. - Moved prompt definitions from inline code to external text files in `src/app/agents/prompts/` - Created a comprehensive configuration system with `AppConfig` class and YAML configuration file - Reorganized API tools into a dedicated `tools` module and refactored import paths accordingly ### Reviewed Changes Copilot reviewed 43 out of 49 changed files in this pull request and generated 4 comments. <details> <summary>Show a summary per file</summary> | File | Description | | ---- | ----------- | | src/app/configs.py | Implements comprehensive application configuration system with YAML loading and model validation | | src/app/agents/prompts/ | Extracts hardcoded prompts into organized text files | | src/app/api/tools/ | Consolidates API tool classes into dedicated module | | tests/ | Updates import paths to reflect new module structure | | configs.yaml | Adds YAML configuration file for application settings | </details> --- <sub>**Tip:** Customize your code reviews with copilot-instructions.md. <a href="/Berack96/upo-appAI/new/main/.github?filename=copilot-instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Create the file</a> or <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">learn how to get started</a>.</sub>

src/app/configs.py

						
				@@ -0,0 +1,232 @@

				import os

copilot-pull-request-reviewer[bot] (Migrated from github.com) commented

2025-10-12 17:56:25 +02:00

This singleton implementation is not thread-safe and can cause issues in concurrent environments. Consider using a proper singleton pattern with locks or removing the singleton behavior if it's not strictly necessary.

copilot-pull-request-reviewer[bot] (Migrated from github.com) commented

2025-10-12 17:56:25 +02:00

Import statements should be placed at the top of the file, not within method bodies. Move this import to the top-level imports section.

copilot-pull-request-reviewer[bot] (Migrated from github.com) commented

2025-10-12 17:56:25 +02:00

Comment should be in English to maintain consistency with code comments throughout the project.

            'disable_existing_loggers': False, # Keeps existing loggers (e.g., third-party loggers)

Comment should be in English to maintain consistency with code comments throughout the project. ```suggestion 'disable_existing_loggers': False, # Keeps existing loggers (e.g., third-party loggers) ```

copilot-pull-request-reviewer[bot] (Migrated from github.com) commented

2025-10-12 17:56:25 +02:00

Comment should be in English to maintain consistency with code comments throughout the project.

                'httpx': {'level': 'WARNING'}, # Too much spam for INFO

Comment should be in English to maintain consistency with code comments throughout the project. ```suggestion 'httpx': {'level': 'WARNING'}, # Too much spam for INFO ```

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Berack/upo-app-agents#27

				`@@ -0,0 +1,232 @@`
				`import os`