Berack/upo-app-agents
0
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Refactor team management #26

Merged
Berack96 merged 14 commits from 21-team-monitoring into main 2025-10-15 14:00:39 +02:00
Conversation 1 Commits 14 Files Changed 11 +281 -133
Berack96 commented 2025-10-10 11:07:21 +02:00 (Migrated from github.com)
Copy Link

This pull request refactors the agent team orchestration and pipeline logic, introducing a new AppTeam class for managing teams of agents and their tools, and simplifying the pipeline's interact method.

  • Agent Team Refactoring and Pipeline Simplification
  • Tool and Event Management Improvements

Waiting to PR since it requires #23 , #24 and maybe #18 to merge to main

Note: this is a second PR since the first one was not drafted but requested directly

This pull request refactors the agent team orchestration and pipeline logic, introducing a new AppTeam class for managing teams of agents and their tools, and simplifying the pipeline's interact method. - Agent Team Refactoring and Pipeline Simplification - Tool and Event Management Improvements Waiting to PR since it requires #23 , #24 and maybe #18 to merge to main **Note**: this is a second PR since the first one was not drafted but requested directly
copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed 2025-10-15 13:45:47 +02:00
copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment
Copy Link

Pull Request Overview

This pull request refactors the agent team orchestration system by introducing a new PipelineInputs class for managing team configuration and simplifying the pipeline's interaction logic. The changes move from a configuration-based approach to a more flexible input-based system that supports async workflows.

  • Introduction of PipelineInputs class to manage team configuration and user selections
  • Refactoring of Pipeline class to use workflow-based execution with async support
  • Removal of ConfigsRun class and create_team_with function in favor of inline team creation

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/app/interface/telegram_app.py Updated to use PipelineInputs instead of ConfigsRun and Pipeline's async interface
src/app/interface/chat.py Refactored to use PipelineInputs and new Pipeline instantiation pattern
src/app/configs.py Removed get_defaults method and moved initialization logic to __init__
src/app/agents/team.py Deleted entire file - team creation logic moved to Pipeline
src/app/agents/pipeline.py Major refactor introducing PipelineInputs, workflow-based execution, and async support
src/app/agents/init.py Updated exports to reflect new classes
src/app/main.py Simplified initialization by removing Pipeline dependency
demos/agno_workflow.py Added new demo file showing workflow usage patterns
configs.yaml Changed default currency from EUR to USD
Comments suppressed due to low confidence (1)

src/app/agents/pipeline.py:1

  • The docstring incorrectly describes this method as choosing the model for the leader, but it actually chooses the team model.
import asyncio

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

## Pull Request Overview This pull request refactors the agent team orchestration system by introducing a new `PipelineInputs` class for managing team configuration and simplifying the pipeline's interaction logic. The changes move from a configuration-based approach to a more flexible input-based system that supports async workflows. - Introduction of `PipelineInputs` class to manage team configuration and user selections - Refactoring of `Pipeline` class to use workflow-based execution with async support - Removal of `ConfigsRun` class and `create_team_with` function in favor of inline team creation ### Reviewed Changes Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment. <details> <summary>Show a summary per file</summary> | File | Description | | ---- | ----------- | | src/app/interface/telegram_app.py | Updated to use `PipelineInputs` instead of `ConfigsRun` and Pipeline's async interface | | src/app/interface/chat.py | Refactored to use `PipelineInputs` and new Pipeline instantiation pattern | | src/app/configs.py | Removed `get_defaults` method and moved initialization logic to `__init__` | | src/app/agents/team.py | Deleted entire file - team creation logic moved to Pipeline | | src/app/agents/pipeline.py | Major refactor introducing `PipelineInputs`, workflow-based execution, and async support | | src/app/agents/__init__.py | Updated exports to reflect new classes | | src/app/__main__.py | Simplified initialization by removing Pipeline dependency | | demos/agno_workflow.py | Added new demo file showing workflow usage patterns | | configs.yaml | Changed default currency from EUR to USD | </details> <details> <summary>Comments suppressed due to low confidence (1)</summary> **src/app/agents/pipeline.py:1** * The docstring incorrectly describes this method as choosing the model for the leader, but it actually chooses the team model. ``` import asyncio ``` </details> --- <sub>**Tip:** Customize your code reviews with copilot-instructions.md. <a href="/Berack96/upo-appAI/new/main/.github?filename=copilot-instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Create the file</a> or <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">learn how to get started</a>.</sub>
src/app/agents/pipeline.py
@@ -1,32 +1,59 @@
import asyncio
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2025-10-15 13:45:47 +02:00
Copy Link

The docstring incorrectly describes this method as choosing the model for the Team, but it actually chooses the team leader model.

        Sceglie il modello LLM da usare per il Team Leader.
The docstring incorrectly describes this method as choosing the model for the Team, but it actually chooses the team leader model. ```suggestion Sceglie il modello LLM da usare per il Team Leader. ```
Sign in to join this conversation.
Reviewers
No Reviewers
copilot-pull-request-reviewer[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 important
This is a core feature that must be worked on as soon as possible
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Berack
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Berack/upo-app-agents#26
Delete Branch "21-team-monitoring"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?