From fc4753a24562c4765bde052835cd57606ce9aefd Mon Sep 17 00:00:00 2001
From: Berack96 <giacomobertolazzi7@gmail.com>
Date: Mon, 29 Sep 2025 19:21:08 +0200
Subject: [PATCH] Add news API functionality and update tests for article
 retrieval

---
 demos/news_api.py          | 16 ++++++++++++++++
 src/app/news/news_api.py   | 11 ++++++-----
 tests/api/test_news_api.py |  2 +-
 3 files changed, 23 insertions(+), 6 deletions(-)
 create mode 100644 demos/news_api.py

diff --git a/demos/news_api.py b/demos/news_api.py
new file mode 100644
index 0000000..0fc4c37
--- /dev/null
+++ b/demos/news_api.py
@@ -0,0 +1,16 @@
+#### FOR ALL FILES OUTSIDE src/ FOLDER ####
+import sys
+import os
+sys.path.append(os.path.abspath(os.path.join(os.path.dirname(__file__), '../src')))
+###########################################
+
+from dotenv import load_dotenv
+from app.news import NewsAPI
+
+def main():
+    api = NewsAPI()
+    print("ok")
+
+if __name__ == "__main__":
+    load_dotenv()
+    main()
\ No newline at end of file
diff --git a/src/app/news/news_api.py b/src/app/news/news_api.py
index 54b210a..ce213cf 100644
--- a/src/app/news/news_api.py
+++ b/src/app/news/news_api.py
@@ -17,16 +17,17 @@ class NewsAPI:
         assert api_key is not None, "NEWS_API_KEY environment variable not set"
 
         self.client = newsapi.NewsApiClient(api_key=api_key)
-        self.category = "business"
-        self.language = "en"
-        self.page_size = 100
+        self.category = "business" # Cryptocurrency is under business
+        self.language = "en" # TODO Only English articles for now?
+        self.max_page_size = 100
 
     def get_top_headlines(self, query:str, total:int=100) -> list[Article]:
-        page_size = min(self.page_size, total)
+        page_size = min(self.max_page_size, total)
         pages = (total // page_size) + (1 if total % page_size > 0 else 0)
+
         articles = []
         for page in range(1, pages + 1):
-            headlines = self.client.get_top_headlines(category=self.category, language=self.language, page_size=page_size, page=page)
+            headlines = self.client.get_top_headlines(q=query, category=self.category, language=self.language, page_size=page_size, page=page)
             results = [result_to_article(article) for article in headlines.get("articles", [])]
             articles.extend(results)
         return articles
diff --git a/tests/api/test_news_api.py b/tests/api/test_news_api.py
index 99a3179..9558882 100644
--- a/tests/api/test_news_api.py
+++ b/tests/api/test_news_api.py
@@ -10,7 +10,7 @@ class TestNewsAPI:
         news_api = NewsAPI()
         articles = news_api.get_top_headlines(query="crypto", total=2)
         assert isinstance(articles, list)
-        assert len(articles) == 2
+        assert len(articles) > 0 # Ensure we got some articles (apparently it doesn't always return the requested number)
         for article in articles:
             assert hasattr(article, 'source')
             assert hasattr(article, 'time')